Rework inheritance for renderer and operators - Githubissues

ynput / LabLib

Create VFX Dailies with Python! Can be used to render directly or as a module extending other code.

MIT License

2 stars 2 forks source link

Rework inheritance for renderer and operators #31

Open robin-ynput opened 1 week ago

robin-ynput commented 1 week ago

Is there an existing issue for this?

[X] I have searched the existing issues.

Please describe the feature you have in mind and explain what the current shortcomings are?

Initially discussed here: https://github.com/ynput/LabLib/pull/27/files#r1801765261

For renderer:

keep BasicRenderer as minimal as possible and rename it RendererBase
move burnins + video/img encoding to a new SequenceRenderer
make SequenceRenderer and SlateRenderer inherit from RendererBase

For operators:

apply same logic for operators

How would you imagine the implementation of the feature?

Are there any labels you wish to add?

[X] I have added the relevant labels to the enhancement request.

Describe alternatives you've considered:

No response

Additional context:

No response

jakubjezek001 commented 1 day ago

The inheritance tree looks great. Let's proceed with your suggestion for the rendering workflow. I propose renaming SequenceRenderer to ClipRenderer since the medium could be either video or an image sequence.

Regarding the operators, let's create a separate issue for that. @tweak-wtf, could you please suggest the inheritance structure? We discussed it some time ago in a meeting, and you know the best approach to implement.