ynput / OpenPype

Main OpenPype repository (to be deprecated)
https://openpype.io
MIT License
284 stars 128 forks source link

Maya: Camera Attribute Validator #2808

Open tokejepsen opened 2 years ago

tokejepsen commented 2 years ago

Describe the bug This validator does not allow any animation on some of the camera attributes.

To Reproduce Steps to reproduce the behavior:

  1. Animate camera film offset attribute
  2. Publish.

Expected behavior It seems like some (if not all) of the attribute that are locked with this validator, do get the data across to the other DCCs (for example Nuke interprets the film offset). So this validator needs to be revised and potentially either be reduced in scope or removed alltogether.

[cuID:OP-6749]

m-u-r-p-h-y commented 2 years ago

We should be very careful here as I saw too many broken scenes just because of animated everything on camera. (like Aperture sizes, aspect ratio, scale etc.) creating too many issues down the line.

Not sure what is the black list of locked attributes and Film Offset specifically should be on the white list as you suggest.

The easiest thing to do would be to make this validator optional, so in these rare cases you could turn it off completely

tokejepsen commented 2 years ago

The easiest thing to do would be to make this validator optional, so in these rare cases you could turn it off completely

We have completely disabled this validator in our config. Will see if we get any issues down the line.

BigRoy commented 1 year ago

It's been a year since. What is the verdict on this issue @tokejepsen @m-u-r-p-h-y ?

tokejepsen commented 1 year ago

Dont have an answer to the direction but something to add that related to this validator is that "camera scale" was a major issue on our most recent production. This attribute does not translate to other DCCs and there is not really a reason for using it since you can just adjust the focal length instead.

m-u-r-p-h-y commented 1 year ago

the best solution imo would be to have a default list of locked attributes in settings (we can discuss what attributes we should include in defaults)

this way every studio can add/remove attributes based on their specific project needs

also making the validator optional (but default on) is the right way to go.