search

ynput / OpenPype

Main OpenPype repository (to be deprecated)
https://openpype.io
MIT License
283 stars 128 forks source link

Kitsu integration stores unnecessary and irrelevant data in OPs DB #4564

Open EmberLightVFX opened 1 year ago

EmberLightVFX commented 1 year ago

Running version 3.15.2-nightly.3

Describe the bug Kitsu integration stores unnecessary and irrelevant data in OPs database. It currently stores ~150+ lines of data while it should only need 1, the zou ID.

To Reproduce Sync data with Kitsu. Check any asset in OP's database and you'll see a lot of extra data not needed for OP operation.

Expected behavior The syncing and creation of OP data should only save the zou ID. Currently the ID is saved under doc["data"]["zou"]["id"] but maybe it would be better to save it as doc["data"]["zou_id"] as no other information should live inside of the zou dict.

update_op_with_zou.py should save only the zou ID of any asset to OPs database. sync_service.py should work with only the zou ID. Currently it's using and saving a lot of other data to OPs database. If doc["data"]["zou"]["id"] is changed to doc["data"]["zou_id"], update_zou_with_op.py needs to be updated to work with the new location for the zou ID

[cuID:OP-5166]

MustafaJafar commented 1 year ago

@EmberLightVFX Does the problem still exist? and, is it similar to this #3602 ?

EmberLightVFX commented 1 year ago

This "problem" still exist and would need quite a big re-write of the Kitsu integration. It's not super important so I think it's very low down on the todo list, probably something that will happen when making it for Ayon.

It's not similar to https://github.com/ynput/OpenPype/issues/3602 It seems like a OP problem as asset_docs[visual_parent_id] has nothing to do with Kitsu from what I can see in the code.