ynput / OpenPype

OpenPype has been surpassed by AYON and is now read only.
https://ayon.ynput.io
MIT License
286 stars 129 forks source link

Bug: Local Render Publish Support in Houdini #5716

Closed moonyuet closed 4 months ago

moonyuet commented 1 year ago

Is there an existing issue for this?

Current Behavior:

When the farm instance disabled in Houdini render ROPs, it doesn't get published after local rendering. See here: https://discord.com/channels/517362899170230292/1159640714649542696/1160121840354734080

Expected Behavior:

It can be locally published to the published folder after the farm, similar to Nuke and FUsion We should support local rendering alongside farm rendering, users can choose their preferences to use whether local or farm for rendering.

Version

3.17.2-nightly.3

What platform you are running OpenPype on?

Windows

Steps To Reproduce:

  1. Create any Render Instance in Houdini and disables farm instance
  2. Publish

Are there any labels you wish to add?

Relevant log output:

No response

Additional context:

No response

[cuID:OP-7093]

moonyuet commented 1 year ago

@fabiaserra for some reason I can't add you as assignee. It would be great you can also join the discussion and come up with some ideas!

BigRoy commented 1 year ago

When the farm instance disabled in Houdini render ROPs, the render doesn't get published after deadline submission

I think this sentence is wrong? :) If farm is disabled then it doesn't submit to Deadline to begin with, right? I assume you meant "doesn't get published after local rendering"?

I personally would just expect - if submitting to the farm can be disabled on the instance - that the behavior is the same as Nuke/Fusion where one just has a render toggle between "Local rendering" or "Render on the farm" - but no matter which option I'd pick I'd at least expect my files to get published. If local render publishes don't get published then they are basically the same as clicking "Save to disk" on the ROP node without a pipeline, right?

Also, if we're tweaking the option I'd also expect an option like with Fusion/Nuke to publish existing frames maybe?

moonyuet commented 1 year ago

When the farm instance disabled in Houdini render ROPs, the render doesn't get published after deadline submission

I think this sentence is wrong? :) If farm is disabled then it doesn't submit to Deadline to begin with, right? I assume you meant "doesn't get published after local rendering"?

It is indeed not elaborated well, I edited the changelog for better description of the issue.

I personally would just expect - if submitting to the farm can be disabled on the instance - that the behavior is the same as Nuke/Fusion where one just has a render toggle between "Local rendering" or "Render on the farm" - but no matter which option I'd pick I'd at least expect my files to get published. If local render publishes don't get published then they are basically the same as clicking "Save to disk" on the ROP node without a pipeline, right?

Also, if we're tweaking the option I'd also expect an option like with Fusion/Nuke to publish existing frames maybe?

We can defnitely expect the options for existing frames in this case. If we take reference from Nuke/Fusion, this is probably what we expect to add technically for local rendering:

  1. A toggled button/option to allow users to choose "local" or "farm" for rendering
  2. Extractor for local rendering(some image sequences) and Extractor which renders image sequences for burnin. (I am thinking if we can just use one extractor for Houdini's case)
  3. If we add burnin for the rendered image sequences, which means the review family needs to be included as part of the family.
MustafaJafar commented 1 year ago

is this issue the same as reported here ? , if yes, please confirm so that I can close the other issue. https://github.com/ynput/OpenPype/issues/5482

BigRoy commented 1 year ago

is this issue the same as reported here ? , if yes, please confirm so that I can close the other issue. #5482

Yes, sounds very similar.

BrutoolsLtd commented 1 year ago

Hello, just following the issue. It maybe a good idea to be able to see the "farm" option when in Publish tab. so you can enable or disable it. Consider that you can Create the "Ynput ROP" directly in Houdini but by default "farm" is enabled, but when you launch "OpenPype publisher" you can not see the option there, so for the "Artist" could be more convenient. image

BigRoy commented 1 year ago

That's also something I assumed was already the case, the farm setting would be a Creator attribute definition get_instance_attr_defs() on the Creator. - so it's a publish attribute first.

BigRoy commented 4 months ago

Pretty sure this is solved in AYON - right @MustafaJafar. Time to close?

MustafaJafar commented 4 months ago

Yes, Pretty sure this is solved in AYON Let's burn it 🔥