AYON: Use `SettingsField` from ayon server

ynput / OpenPype

OpenPype has been surpassed by AYON and is now read only.

https://ayon.ynput.io

MIT License

286 stars 129 forks source link

AYON: Use `SettingsField` from ayon server #6173

Closed iLLiCiTiT closed 8 months ago

iLLiCiTiT commented 8 months ago

Changelog Description

This is preparation for new version of pydantic which will require to customize the field class for AYON purposes as raw pydantic Field could not be used.

Testing notes:

Create server packages.
Upload packages to AYON server.
Restart server.
Add the addon versions to a bundle.
Try to open each addon settings (all of them should be visible and working).

[x] aftereffects
[x] applications
[x] blender
[x] celaction
[x] clockify
[x] core
[x] deadline
[x] fusion
[x] hiero
[x] houdini
[x] max
[x] maya
[x] nuke
[x] photoshop
[x] resolve
[x] royal render
[x] substancepainter
[x] timers manager
[x] traypublisher
[x] tvpaint
[x] unreal

BigRoy commented 8 months ago

Interesting - outside of this PR this could have quite an influence on anyone having customized settings on top of AYON. They would need to align.

Not sure when the pydantic update is 'scheduled' but it would be good to maybe make a clear announcement to devs to make sure to refactor along because say "in a month" or so pydantic will update and using Field will start to fail.

iLLiCiTiT commented 8 months ago

Not sure when the pydantic update is 'scheduled' but it would be good to maybe make a clear announcement to devs to make sure to refactor along because say "in a month" or so pydantic will update and using Field will start to fail.

It is not scheduled at this moment. I think it will happen when all addons will be separated, pre-requirement for separation is to renamed openpype to ayon_core, so they'd have to do more changes than this anyway...