search

ynput / OpenPype

Main OpenPype repository and AYON openpype addon codebase
https://openpype.io
MIT License
280 stars 128 forks source link

Publisher: Show message with error on action failure #6179

Closed tokejepsen closed 5 months ago

tokejepsen commented 5 months ago

Changelog Description

This PR adds support for the publisher to show error message from running actions.

Errors from actions will otherwise be hidden from user in various console outputs.

Also include card for when action is finished.

Testing notes:

Not sure about a simpler test case, so this where I caught it.

  1. Checkout #6137
  2. Merge this PR into the checked out PR.
  3. In ayon+settings://nuke/create/CreateWriteRender/exposed_knobs enter an invalid knob name like create_directo.
  4. Create render in Nuke. Error will appear about missing knob.
  5. Delete knob create_directo on the created instance node.
  6. Validate and run repair action. Error message should appear.
BigRoy commented 5 months ago

Could you share a screen capture of what this looks like? Does the error show in the Report?

I'm asking because it has also often come up that there's also NO response whatsoever from a succesful run of an action where the action does produce logs and preferably that output would be visualized. I wonder whether that case could also be solved with code similar to this.

tokejepsen commented 5 months ago

Could you share a screen capture of what this looks like? Does the error show in the Report?

Its separate pop-up window, similar to when creation fails.

Capture

I've just snug in code for displaying "Action finished." similar to the "Refreshed" card. Shh....