Bug: Action failed window doesn't show up

JoseCaraballoOS commented 4 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:

PR #6179 introduced a new feature where a window will display the error and stack trace of a failed action.

This feature is not working because the wrong arguments were passed to the function. Here you can see what is displayed in the Maya script editor console. ERROR-ACTION

Expected Behavior:

Expected behavior is for a window to appear and display the error like this: ACTION-WORKING

Version

3.18.8-nightly.1

What platform you are running OpenPype on?

Linux / Centos

Steps To Reproduce:

Make an action fail on purpose and run it. "Action Failed" window won't show up.

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:

No response

Additional context:

No response

JoseCaraballoOS commented 4 months ago

I'm not sure if a PR is needed in AYON.

tokejepsen commented 4 months ago

I'm not sure if a PR is needed in AYON.

Sure does :) https://github.com/ynput/ayon-core/pull/120

JoseCaraballoOS commented 4 months ago

Thanks :D. Now that the related PR has been merged in to develop, should I close the issue or should I close it once it has been officially released?

tokejepsen commented 4 months ago

Let's close it.

ynput / OpenPype