Farm Render jobs collect env using launch type "farm_publish" instead of "farm_render" - Githubissues

ynput / ayon-applications

AYON addon to maintain applications

Apache License 2.0

3 stars 3 forks source link

Farm Render jobs collect env using launch type "farm_publish" instead of "farm_render" #2

Open BigRoy opened 1 month ago

BigRoy commented 1 month ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior:

Recent refactoring seems to have changed the launch type for extractenvironments logic as used by e.g. the Deadline's GlobalJobPreLoad logic.

It currently seems to force LaunchTypes.farm_publish in the logic here - also since 0.3.0

Previously it was e.g. LaunchTypes.farm_render in Ayon Core 0.2.1 and also in OpenPype

The LaunchTypes.farm_render currently even seems unused?

Expected Behavior:

Elaborate the differences between the two - and use the correct one when relevant.

I assume for the deadline render jobs it should be using the LaunchTypes.farm_render?

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

Pre launch hooks with LaunchTypes.farm_render do not run in deadline render.

Are there any labels you wish to add?

[X] I have added the relevant labels to the bug report.

Relevant log output:

No response

Additional context:

No response

BigRoy commented 1 month ago

It seems to have been changed here: https://github.com/ynput/ayon-core/pull/297/files#diff-2941b87a47067ff6165b8f040a8b4d01bca34f99d589f4a918275c1bcbc59696L103-L171