search

ynput / ayon-applications

AYON addon to maintain applications
Apache License 2.0
3 stars 4 forks source link

Add section names to settings #20

Closed MustafaJafar closed 2 weeks ago

MustafaJafar commented 2 weeks ago

Changelog Description

This PR provides extra clarity about different sections in the addon settings by add section names for settings.

image

Additional info

Motivation: the wip application addon documentation is mentioning two main categories/layers for application settings. So, I thought about reflecting that in the settings.

Testing notes:

Everything should work as usual

Innders commented 2 weeks ago

I can understand the motivation behind it but I also agree with @BigRoy. I had to inspect the code to actually spot the difference.

BigRoy commented 2 weeks ago

I can understand the motivation behind it but I also agree with @BigRoy. I had to inspect the code to actually spot the difference.

@Innders Does that mean you approve or disapprove? Or have other comments?

MustafaJafar commented 2 weeks ago

I'm not completely convinced it's needed but it does look clearer at first sight so fine by me.

It's not needed. but it looks nicer in the docs. image

BigRoy commented 2 weeks ago

I'd say - merge this. It's cosmetics, and doesn't affect settings much if we redesign later?