Open iLLiCiTiT opened 2 months ago
The PR title does not match at all what the code changes do - Something is wrong? :)
This is my unit scale setting for blender in AYON(for matching the default unit scale in maya) Publish successfully
The animation loaded correctly, but the loaded fbx seems to be a bit off( I guess it is related to the scene_length you mentioned above)
@moonyuet speaking of animation and offset be aware of the Fps
as it has huge impact on timeline aka loading animations for e.g. 25fps
vs 24fps
, just sayin...doesnt mean thats the issue atm
@moonyuet speaking of animation and offset be aware of the
Fps
as it has huge impact on timeline aka loading animations for e.g.25fps
vs24fps
, just sayin...doesnt mean thats the issue atm
If this is dangerous, guess we should also need to remove the fps option in the scene overrides so that users won't publish assets with weird fps type.
Unassigning myself since I may not be the best to continue this without clear pointers on what is "good" Blender behavior.
Tagging @LiborBatek @moonyuet for visibility - anyone who may be a better fit? Or should I just include Kayla's notes - do a simple test run and then assume I haven't broken other critical blender parts?
Can someone take care of this PR? @BigRoy @moonyuet ?
@moonyuet maybe outside of scope of this PR but as we will introduce frame range
on each publish instance...I would like to point out that we completely lack Validate Frame range
on the Context
widget as in e.g. Maya host. Shouldnt we introduce it for blender too?!
Edit: we lack it also on each publish instance, which should be very useful feature to have...again not sure what that means in terms of dev time/refactoring
@moonyuet maybe outside of scope of this PR but as we will introduce
frame range
on each publish instance...I would like to point out that we completely lackValidate Frame range
on theContext
widget as in e.g. Maya host. Shouldnt we introduce it for blender too?!
yes we should include these families to the validate frame range, but with different PR
Is this ready for review?
Is this ready for review?
Is this ready for review?
yes, @LiborBatek and @BigRoy can you review?
I can see the frame range
settings for each publish instance which is good but the UI lacks Unit Scale
settings...am I correct when expecting it to be shown in the publisher UI?!
been tested on these publish instances:
animation model pointcache camera review
Changelog Description
Improved creators and publish instances to allow per instance frame ranges to be configured instead of using folder-level attributes.
Additional info
Note: A caveat of this is that now the frame ranges of instances aren't 1:1 tied to the scene's frame range but to what is configured on the publish instance in the publisher UI.
Transferred PR from https://github.com/ynput/ayon-core/pull/658
Testing notes:
The creators and the extractors that have been updated should be tested to check if they're using the information set in the creator.
FBX extractors should now have a Unit Scale attribute that works in a sensible manner:
All Extractors should now adhere to a frame range configured on the instance instead of exporting all.