search

ynput / ayon-blender

Blender addon for AYON
Apache License 2.0
6 stars 2 forks source link

enhancement/AY-6116-blender_allow_handles_frame_range #28

Closed jrsndl closed 1 week ago

jrsndl commented 1 week ago

Changelog Description

Allows to configure in settings whether a workfile frame range should include the handles or not for certain tasks. The default is like before where handles are excluded from the timeline.

Additional info

Should address the issue #27

Matches a similar feature in ayon-maya.

Testing notes:

  1. Upload new addon
  2. Tweak the settings for Including handles or not
  3. Trigger set frame range
BigRoy commented 1 week ago

Resolved the conflicts, pushed some cosmetic fixes and updated the PR description and added reviewers. Happy testing @LiborBatek 🫶

BigRoy commented 1 week ago

@LiborBatek how about the case that Kayla mentioned:

When I enable the include_handles_default, the setting works as expected. But setting up the handle does not work when the task type being enabled,

When the include_handles_default settings is disabled, and with the tasktype filtering system set up, all the handles in all task types are not set up by clicking the set frame range.

It sounds like @moonyuet says the task type filtering does not work as intended, or?

Should be fixed with https://github.com/ynput/ayon-blender/pull/28/commits/0d7d2e5190721aa46912e9e1e24fe0864850f0ca

BigRoy commented 1 week ago

I had a look at the Maya implementation here and I think I fixed it with https://github.com/ynput/ayon-blender/pull/28/commits/0d7d2e5190721aa46912e9e1e24fe0864850f0ca @moonyuet could you confirm?