search

ynput / ayon-core

Apache License 2.0
25 stars 31 forks source link

Chore: Move substance painter client code #517

Closed moonyuet closed 3 months ago

moonyuet commented 3 months ago

Changelog Description

This PR is to move substance painter integration into the client code for the sake of splitting repos for each host in the future.

Additional info

Test both dev mode and build addon.

Testing notes:

Dev Mode

  1. Build substance painter addon with python ./server_addon/create_ayon_addons.py --skip-zip --addon substancepainter
  2. Use <your_ayon_core_repo>\server_addon\substancepainter\client as the addon directory for substance addon and ``\client``` for core addon
  3. Launch AYON in dev mode
  4. Publishing and Loading should be working as expected.

Build Mode

  1. Build substance painter addon with python ./server_addon/create_ayon_addons.py --addon substancepainter and run create_package.py to build core addon
  2. Install substance painter and core addons
  3. Launch AYON
  4. Publishing and Loading should be working as expected.
ynbot commented 3 months ago

Task linked: AY-4920 Move SubstancePainter client code

LiborBatek commented 3 months ago

Im also attaching full JSON report here

publish-report-240529-11-15.json.txt

LiborBatek commented 3 months ago

this issue also happens when using addon package aka non developer mode of AYON.

image

iLLiCiTiT commented 3 months ago

Im getting integrate asset errors when in dev mode....

I don't know full context so you may ignore this: We've removed family filtering from IntegrateAsset plugin. If the instance should not be integrated then it should set instance.data["integrate"] = False.

moonyuet commented 3 months ago

Im getting integrate asset errors when in dev mode....

I don't know full context so you may ignore this: We've removed family filtering from IntegrateAsset plugin. If the instance should not be integrated then it should set instance.data["integrate"] = False.

it is already set: https://github.com/ynput/ayon-core/blob/b8abd1fbb933717e628f1420f6e292c0b07a9057/server_addon/substancepainter/client/ayon_substancepainter/plugins/publish/extract_textures.py#L67

iLLiCiTiT commented 3 months ago

@LiborBatek please re-test, and if you hit the same issue DM Kayla for faster resolve.