search

ynput / ayon-core

Apache License 2.0
27 stars 32 forks source link

Blender: Use task level attributes instead of asset #658

Closed simonebarbieri closed 3 months ago

simonebarbieri commented 3 months ago

Changelog Description

Improved creators to set up scene properties instead of using asset-level attributes.

Testing notes:

The creators and the extractors that have been updated should be tested to check if they're using the information set in the creator.

ynbot commented 3 months ago

Task linked: AY-5632 use task level attributes instead of asset

BigRoy commented 3 months ago

For what it's worth - looking at the code I see nothing related to "task level attributes" versus asset level attributes. Is the PR title and description wrong maybe?

moonyuet commented 3 months ago

Regarding to the comment above, we need to also adjust the get_folder_attributes function in pipeline.py. And there should be possible change of the function name. Instead of merely using folder entity, we use task entity and we can use the folder entity as backward compatibility(maybe or maybe not). The function which can get the related data from task entity(take below as example)


from ayon_core.pipeline.context_tools import get_current_task_entity
task_attributes = get_current_task_entity(fields={"attrib"})["attrib"]
iLLiCiTiT commented 3 months ago

PR moved to ayon-blender repository https://github.com/ynput/ayon-blender/pull/1