ynput / ayon-core

Apache License 2.0
18 stars 30 forks source link

Houdini: Fix single frame publishes #675

Closed BigRoy closed 2 weeks ago

BigRoy commented 2 weeks ago

Changelog Description

The instance.data["frames"] in the CollectFrames plug-in stores a str if it's a single frame but a list if it's multiple files, similar to how the Integrator currently likes it.

However, there was some scattered logic that seemed to assume that instance.data["frames"] was always a List[str] which isn't expected anymore now.

Additional info

Fixes #672

I feel like it'd still be worth it to start moving into logic where there's a single ExtractROP plug-in that works the same for all ROP nodes because the shared logic across them is 99% the same, and where it currently isn't it should become the same. So I may follow up with another PR after this to start working to a single ExtractROP plug-in.

Testing notes:

  1. All Houdini publishes types should allow to publish single frame and multi-frame publishes without issue.
BigRoy commented 2 weeks ago

Closing this in favor of #676