search

ynput / ayon-core

Apache License 2.0
18 stars 30 forks source link

Creators: Type hints + cosmetics #696

Closed BigRoy closed 1 week ago

BigRoy commented 1 week ago

Changelog Description

Improve some type hints on the Creators just so I hate my IDE and the code less.

Additional info

Also fixes a few grammar bits here and there.

Testing notes:

  1. Creating instances should still work
  2. Publishing should still work

Might be good to also test in a version that has older Py3 (e.g. Maya 2020 or whatever) to ensure none of the changes are Py3.x+ specific.

kalisp commented 1 week ago

Is this something else than https://github.com/ynput/ayon-core/pull/366 ?

BigRoy commented 1 week ago

Is this something else than #366 ?

Fuck me. I just knew that I did this before... I'll merge this into that PR. Thanks.