ynput / ayon-core

Apache License 2.0
18 stars 30 forks source link

Houdini: Fix CreateHDA for Houdini 20+ #698

Closed BigRoy closed 19 hours ago

BigRoy commented 1 week ago

Changelog Description

Fix CreateHDA import, refactor setToolSubmenu -> setTabSubMenu for recent Houdini versions

Additional info

Fixes #697

Testing notes:

  1. No errors should show upon startup of Houdini, in both Houdini 19 and 20
  2. Create HDA and publishing should work in Houdini 19 and 20
BigRoy commented 1 week ago

HDAs published from Houdini 20.0 don't keep their submenu. In my screenshot. the HDA includes uppercaseS was published from Houdini 19.5.

Could you show what it looks like when published from Houdini 20? Also, do you need me to debug why this is happening and fix it? or are you looking into it?

MustafaJafar commented 1 week ago

Yeah, they are not the same. Also, I wonder who are Attila and Jeff image

MustafaJafar commented 1 week ago

Could you show what it looks like when published from Houdini 20? Also, do you need me to debug why this is happening and fix it? or are you looking into it?

I update my comment above and added a quick screen record. Currently, I'm comparing the two functions.

BigRoy commented 1 week ago

Also, I wonder who are Attila and Jeff

Very likely:

MustafaJafar commented 1 week ago

Also, I wonder who are Attila and Jeff

Very likely:

😮😮😮

MustafaJafar commented 1 week ago

@fabiaserra could you let us know what do you think about setting HDA's submenu location ? I found this some time ago Setting HDA tab submenu name via python? which is similar to assettools.setToolSubmenu logic in Houdini 19.5.

For context, assettools.setToolSubmenu in Hou 19.5 was refactored to assettools.setTabSubMenu in Hou 20.0 assettools.setToolSubmenu sets the sub menu location permanently while assettools.setTabSubMenu sets the sub menu interactively (which requires the user to click apply in the HDA type properties window)

For reference, I used to use the same logic as assettools.setTabSubMenu but I replaced it with assettools.setToolSubmenu. https://github.com/ynput/ayon-core/commit/17ec19f5069860be184733254db79f4a86308de5

fabiaserra commented 1 week ago

@fabiaserra could you let us know what do you think about setting HDA's submenu location ?

I'm not sure what do you want me to check?

BigRoy commented 19 hours ago

Thanks for merging - be aware that this PR did not have a version bump which it should have. If we merge the USD one now quickly we should be fine - then it'd just contain both in one version bump.