ynput / ayon-core

Apache License 2.0
26 stars 31 forks source link

Ftrack: Have single place where ftrack family is assigned #831

Open iLLiCiTiT opened 1 year ago

iLLiCiTiT commented 1 year ago

Is there an existing issue for this?

Please describe the feature you have in mind and explain what the current shortcomings are?

Assignment of ftrack family is already cleaned up in the codebase a lot, but there are still places where it's hardcoded in extractors and collectors of host integration. It's off and the feeling of it is confusing. Also deadline is adding ftrack family to every instance that is submitted -> that's the worst usecase I think.

How would you imagine the implementation of the feature?

Remove the family assignement which are not inside ftrack module and figure out if they were necessary or were already handled by settings. If were needed then try to handle them by settings, otherwise add customized ftrack plugins for the specific usecase (I hope this won't happen). Deadline probably should not be acknowledged about the ftrack family at all and should collect ftrack family decide if it's needed or not.

Are there any labels you wish to add?

Describe alternatives you've considered:

No response

Additional context:

Places in code: Houdini - collect review Maya - collect review Harmony - collect instances Editorial - Colect editorial resources

[cuID:OP-5902]

BigRoy commented 1 month ago

This is still relevant @iLLiCiTiT - should we move to ayon ftrack?

iLLiCiTiT commented 1 month ago

Still relevant, But not sure if really relevant for ayon-ftrack, as he can't affect it. It happened in other addons (I think maya and nuke did it).

BigRoy commented 1 month ago

The issue says:

Places in code: Houdini - collect review Maya - collect review Harmony - collect instances Editorial - Colect editorial resources

  • Collect OTIO review Deadline - Submit publish job (_solve_families and families_transfer) RoyalRender - Collect sequences from job Global - Collect rendered files

So I guess we'll just track it on ayon-core for now then.