ynput / ayon-core

Apache License 2.0
32 stars 36 forks source link

Publisher: handling of exceptions on publish #949

Open antirotor opened 1 month ago

antirotor commented 1 month ago

Is there an existing issue for this?

Please describe the feature you have in mind and explain what the current shortcomings are?

Whenever you hit publish or validate buttons and something happens in underlaying host code (some exception happens) , there might not be any feedback at all, except the fact that the publishing never started.

How would you imagine the implementation of the feature?

We should probably catch exception somewhere here:

https://github.com/ynput/ayon-core/blob/d759c9b41ad1a4efb4195f0ac9f29b93d279c2a9/client/ayon_core/tools/publisher/window.py#L824-L846

and perhaps display the exception itself using QtWidgets.QMessageBox.critical() or similar.

Are there any labels you wish to add?

Describe alternatives you've considered:

No response

Additional context:

No response

BigRoy commented 1 month ago

This would be very nice with a reproducable example actually. Any idea how to get that to fail?

antirotor commented 1 month ago

This would be very nice with a reproducable example actually. Any idea how to get that to fail?

You can raise Exception in host.update_context_data() for example, that one is called before validate and publish.