ynput / ayon-deadline

Deadline addon for AYON
Apache License 2.0
3 stars 11 forks source link

Standardize notation of farm destined instance #57

Open kalisp opened 1 week ago

kalisp commented 1 week ago

Is there an existing issue for this?

Please describe the feature you have in mind and explain what the current shortcomings are?

Currently we are marking farm destined instances with instance.data["farm"] = True and we are checking against it.

This flag is also important to show farm only attribute definitions (for JobInfo for example) in Publisher UI.

Suggested implementation?

There should be added new method is_farm_instance to encapsulate it and replace all existing uses of old one to allow changes in logic in single place.

Describe alternatives you've considered:

No response

BigRoy commented 1 week ago

I'd actually like to make it so that the we use farm family instead and have it listed by the creators - as per https://github.com/ynput/ayon-core/pull/973

I mean - doing it based on instance.data.get("farm") tecnically isn't that different, but by using families like that it also allows us to ensure that we're always targeting our deadline plug-ins to run on them as intended if they happen to have the farm family. and we can remove the whole FARM_FAMILIES constant which generates issues between e.g. Tray Publisher, Fusion, Maya, etc. where in tray publisher e.g. a render instance may not support farm publishing at all, but a maya one does. But with the #49 PR suddenly tray publisher will also show those attributes?