search

ynput / ayon-hiero

Hiero addon for AYON
Apache License 2.0
2 stars 2 forks source link

Publishing: Use new create system with new publisher #1

Open iLLiCiTiT opened 2 months ago

iLLiCiTiT commented 2 months ago

Recreated PR from https://github.com/ynput/ayon-core/pull/87

Not sure how much value the changes have as were done before ayon-python-api and most of the code still uses OpenPype naming.

robin-ynput commented 4 days ago

@iLLiCiTiT I'm started on this task again and going to use this PR as a reference. Reviewing-wise, what should we do with this one ? Shall I tweak it into a working version or do you want me to close it and start from fresh ?

iLLiCiTiT commented 4 days ago

@iLLiCiTiT I'm started on this task again and going to use this PR as a reference. Reviewing-wise, what should we do with this one ? Shall I tweak it into a working version or do you want me to close it and start from fresh ?

As description says, it is recreation of https://github.com/ynput/ayon-core/pull/87 which was not created by me.

I don't know how outdated the PR is, but it looks like it is. Some parts can be re-used, e.g. HieroHost, but it looks like some changes made it more OpenPype-like. So from my point of view, you can start over and copy-paste what is useful from here.

jakubjezek001 commented 2 hours ago

Shall I tweak it into a working version or do you want me to close it and start from fresh ?

Looking quickly into the code and it seems to me that it was adaptation of the https://github.com/ynput/ayon-resolve/pull/3. But Ultimatelly this should look more like https://github.com/ynput/ayon-resolve/pull/15 anyway so it is really up to you what way you will go.