ynput / ayon-hiero

Hiero addon for AYON
Apache License 2.0
3 stars 2 forks source link

framerange missmatch #2

Open timsergeeff opened 4 months ago

timsergeeff commented 4 months ago

Is there an existing issue for this?

Current Behavior:

When i crate publisheble clip and publish it will go with wrong frame range: one frame less than nedeed so further publishing for example from nuke isnt working because of a out of frame range error. I mean that AYON reads frame range corectely, but publishes one frame shorter version

Expected Behavior:

Correct frame range

Version

1.0.0

What platform you are running on?

Windows

Steps To Reproduce:

1) take any video file (my test was mov apple prores 25fps) 2)put it inside timeline 3)trin it to 10 frames 3) create publisheble shot with 10 frames handles 4) publish a shot('s) 6)see published shot is 29 frames long but in AYON datadasae it is 30

Are there any labels you wish to add?

Relevant log output:

No response

Additional context:

Hiero 15

Resolve has the same error (https://github.com/ynput/ayon-resolve/issues/8)

timsergeeff commented 4 months ago

i just discovered that problem is only with prores files and i think in ffmpeg trimming proccess because with mp4 h264 source in works fine Снимок экрана 2024-07-09 025232

jakubjezek001 commented 1 month ago

Hi @timsergeeff, thank you for reporting this issue. We are currently redesigning the Hiero editorial publishing, and as part of this process, we reviewed the OTIO frame range calculations. Here are some updates in ayon-core that may fix the issue. Please update your server to the latest version of ayon-core and test the workflow again.

Fixes by @robin-ynput:

Additionally, there is an open PR for migrating Hiero into the current publisher: #14.

If you have a chance to test it and provide feedback, that would be fantastic! 💯