search

ynput / ayon-hiero

Hiero addon for AYON
Apache License 2.0
3 stars 2 forks source link

Publishing reviewable attributes enhancements #24

Closed jakubjezek001 closed 2 weeks ago

jakubjezek001 commented 3 weeks ago

Changelog Description

Instance attributes for reviewable items with interactivity involve two key elements for proper distribution: setting either a reviewable track or simply flagging for later extraction by transcoding tools. Either of the option will interact with the other.

Additional info

closes #21

Testing notes:

  1. Open the Hiero testing project and create a clip with the reviewable track selected.
  2. After instances are created, set the reviewable track to <none>. You'll see a new attribute for the review switch.
  3. Use the switch to activate the review. Notice that the option to select a 'reviewable track' will disappear.
iLLiCiTiT commented 3 weeks ago

It is a littble bit weird that the checkbox hides the enum, and the same enum hides the checkbox. Only one of them should do it...

It should either always show checkbox, and in that case selection of review track is mandatory (without < none >). Or allow to select review track with < none >, and the checkbox is shown when is not set to < none >, this solution does not make sense to me, if I choose review track, I want review, or (the checkbox is duplication of the < none > value)?

MustafaJafar commented 2 weeks ago

Is this the intended result? if yes, tell me to approve. Animation_33

jakubjezek001 commented 2 weeks ago

Is this the intended result? if yes, tell me to approve.

yes please, shane the label size of the hidden attribute is alwais breaking the look. @iLLiCiTiT is there perhaps a way to define the size of column even by hidden attributes so it is not jumpy?

BigRoy commented 2 weeks ago

yes please, shane the label size of the hidden attribute is alwais breaking the look. @iLLiCiTiT is there perhaps a way to define the size of column even by hidden attributes so it is not jumpy?

In this case maybe just 'disabling' instead of hiding could be sufficient?

iLLiCiTiT commented 2 weeks ago

I vote for disabling it instead of changing visibility. Because I don't know how to do it with label...