ynput / ayon-houdini

Houdini addon for AYON
Apache License 2.0
11 stars 9 forks source link

AY-6773_wrong camera aperture #106

Closed ynbot closed 3 weeks ago

ynbot commented 2 months ago

Please describe the issue you have acountered?

When loading it the aperture is wrong and it changes the framing a lot. If I import the publish manually, then the aperture is right.

How to replicate the issue?

No response

Additional context:

link to discussion on Discord (might be a private channel)

This issue was automatically created from Clickup ticket AY-6773

BigRoy commented 2 months ago

This is due to logic implemented originally here: https://github.com/ynput/OpenPype/pull/5584

Some more notes about this reported issue:

The non-working expression in AYON load:

root = hou.pwd().node('../../..')
aperture = __import__("_alembic_hom_extensions").alembicGetCameraDict(root.hdaModule().GetFileName(root), '/path/to/camera', root.evalParm("frame")/root.evalParm("fps")).get('aperture')
# Match maya render mask (logic from Houdini's own FBX importer)
node = hou.pwd()
resx = node.evalParm('resx')
resy = node.evalParm('resy')
aspect = node.evalParm('aspect')
aperture *= min(1, (resx / resy * aspect) / 1.5)
return aperture

Houdini's own default working expression:

root = hou.pwd().node('../../..')
return __import__("_alembic_hom_extensions").alembicGetCameraDict(root.hdaModule().GetFileName(root), '/path/to/camera', root.evalParm("frame")/root.evalParm("fps")).get('aperture')