search

ynput / ayon-houdini

Houdini addon for AYON
Apache License 2.0
11 stars 9 forks source link

Fix textures not being collected and published along for `look` products #156

Closed BigRoy closed 3 weeks ago

BigRoy commented 3 weeks ago

Changelog Description

Fix textures not being collected and published along for look products.

Additional review information

This PR https://github.com/ynput/ayon-houdini/pull/145 made it so that the USD stage and layers is collected once globally for an instance and then accessed downstream by other plug-ins. However, the Collect Look Assets plug-in, using this data runs at the same collector order and hence depending on "chance" that plug-in may load before or after the this one making it unreliable.

Testing notes:

  1. Publish "look" for an asset with textures
  2. The textures should be published along and remapped accordingly.
BigRoy commented 3 weeks ago

im not sure how to to best test the "unreliable" aspect tho.

Basically - loading the USD layer should be using the remapped local resources. If so, I'd say it's reliably doing what we expect it to. @Lypsolon

Lypsolon commented 3 weeks ago

im not sure how to to best test the "unreliable" aspect tho.

Basically - loading the USD layer should be using the remapped local resources. If so, I'd say it's reliably doing what we expect it to. @Lypsolon

ohhh man i was writing a long text but just realised i read your text wrong. soo yes its using the right path /home/ynput/Documents/Ayon_ Server_Mount/Usd_Testing/Roy_Tests/Houdini/Usd_Pub/https___github_com_ynput_ayon _houdini_pull_156/publish/look/lookMain/v003/resources/m4.jpg (i sourced the image from /home/ynput/pictures) but it might be interesting to know that even with the usd remap relative paths on its an abs path.

if this is intended then i say its good to go.