ynput / ayon-houdini

Houdini addon for AYON
Apache License 2.0
11 stars 9 forks source link

Houdini `20.5`: Use the new cop nodes (Copernicus network) for `imagesequence` product #182

Open MustafaJafar opened 4 days ago

MustafaJafar commented 4 days ago

Is there an existing issue for this?

Please describe the feature you have in mind and explain what the current shortcomings are?

imagesequence product in Houdini 20.5 should use the new cop nodes (Copernicus network) while in 19.5 it should use the old cop nodes.

Currently, publishing imagesequence product in Houdini 20.5 doesn't work.

some testing in Houdini 20.5 Currently, this validator [ValidateCopOutputNode](https://github.com/ynput/ayon-houdini/blob/develop/client/ayon_houdini/plugins/publish/validate_cop_output_node.py) fails because the logic conflicts: - [`not isinstance(output_node, hou.CopNode)`](https://github.com/ynput/ayon-houdini/blob/fb03bd0b91bbf7c9ef701b940eae40884ec56c2a/client/ayon_houdini/plugins/publish/validate_cop_output_node.py#L53) is true for the new cop nodes and false for the old cop nodes - [`output_node.type().category().name() != "Cop2"`](https://github.com/ynput/ayon-houdini/blob/fb03bd0b91bbf7c9ef701b940eae40884ec56c2a/client/ayon_houdini/plugins/publish/validate_cop_output_node.py#L65) is false for the new cop nodes and true for the old cop nodes

More info

In Houdini 19.5, hou.CopNode is a Cop/Composition node in image network. In Houdini 20.5, hou.CopNode is a Cop node in a Copernicus network while the old cop nodes that live inside an image network became hou.Cop2Node

This is somehow makes us support the new Copernicus network out of the box because we are mostly using hou.CopNode along the code.

Some screenshots to tell them apart.

Image Image Image

Suggested implementation?

The whole logic should be revised to ensure that it works in both cases 19.5 and 20.5.

Describe alternatives you've considered:

No response