IntegrateKitsuNote issues

ynput / ayon-kitsu

Official AYON<->Kitsu intetgration (WIP)

Apache License 2.0

8 stars 5 forks source link

IntegrateKitsuNote issues #37

Closed scottmcdonnell closed 6 months ago

scottmcdonnell commented 6 months ago

As reported here

custom comment template (minified markdown doesn't work on my kitsu. but a mix between markdown and \n worked).
IntegrateKitsuNote settings are not applied. (I was able to get screenshots in this PR by modifying IntegrateKitsuNote class attributes)
IntegrateKitsuNote logic is hard for me. especially family_requirements and the fact it's a Context Plugin

For me set_status_note remains False when you set to True in the settings. The note status is not updated.

EmberLightVFX commented 6 months ago

This is because settings_category is missing in the integrate_kitsu_note, so the plugin don't read the settings. I have fixed this in this PR: https://github.com/ynput/ayon-kitsu/pull/33

scottmcdonnell commented 6 months ago

Great, let me test that.

scottmcdonnell commented 6 months ago

PR #33 works great. I have added #39 that addresses the custom comment template.

EmberLightVFX commented 6 months ago

https://github.com/ynput/ayon-kitsu/pull/33 is now merged so this issue can be closed :)