ynput / ayon-kitsu

Official AYON<->Kitsu intetgration (WIP)
Apache License 2.0
7 stars 4 forks source link

Upload Reviews to Kitsu from Houdini #51

Closed MustafaJafar closed 3 days ago

MustafaJafar commented 2 months ago

Hello, I'd like to report to issues:

  1. Support uploading review from Houdini. Basically, I was able to achieve that by adding review family to these two lines. https://github.com/ynput/ayon-kitsu/blob/d59b9dbe78ffcb5989ee99ce6f35d04a9f2d28f9/client/ayon_kitsu/plugins/publish/integrate_kitsu_note.py#L15 https://github.com/ynput/ayon-kitsu/blob/d59b9dbe78ffcb5989ee99ce6f35d04a9f2d28f9/client/ayon_kitsu/plugins/publish/integrate_kitsu_review.py#L13
  2. The previous modification worked for me until, recently I started seeing this strange error. my mp4 file is a valid file and I can open it.
    DEBUG: Found review at: \\storage\work\ayon_projects\Robo\Assets\Character\bigrobo\publish\review\reviewMain\v014\robo_bigrobo_reviewMain_v014_h264.mp4
    DEBUG: http://192.168.1.4:8800 "POST /api/actions/tasks/fa73d6f0-7a4e-497d-98c0-60415f1a389f/comments/f6294d50-1def-4f13-9dba-337959060e75/add-preview HTTP/1.1" 500 2965
    Traceback (most recent call last):
      File "C:\Users\<my-user-name>\AppData\Local\Ynput\AYON\dependency_packages\ayon_2307191209_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
        runner(*args)
      File "E:\Ynput\ayon-kitsu\client\ayon_kitsu\plugins\publish\integrate_kitsu_review.py", line 35, in process
        gazu.task.add_preview(
      File "C:\Users\<my-user-name>\AppData\Local\Ynput\AYON\dependency_packages\ayon_2307191209_windows.zip\dependencies\gazu\task.py", line 919, in add_preview
        preview_file = create_preview(
      File "C:\Users\<my-user-name>\AppData\Local\Ynput\AYON\dependency_packages\ayon_2307191209_windows.zip\dependencies\gazu\task.py", line 870, in create_preview
        return raw.post(path, revision, client=client)
      File "C:\Users\<my-user-name>\AppData\Local\Ynput\AYON\dependency_packages\ayon_2307191209_windows.zip\dependencies\gazu\client.py", line 230, in post
        check_status(response, path)
      File "C:\Users\<my-user-name>\AppData\Local\Ynput\AYON\dependency_packages\ayon_2307191209_windows.zip\dependencies\gazu\client.py", line 326, in check_status
        raise ServerErrorException(path)
    gazu.exception.ServerErrorException: actions/tasks/fa73d6f0-7a4e-497d-98c0-60415f1a389f/comments/f6294d50-1def-4f13-9dba-337959060e75/add-preview

    Also, when I tried to perform the above query actions/tasks/fa73d6f0-7a4e-497d-98c0-60415f1a389f/comments/f6294d50-1def-4f13-9dba-337959060e75/add-preview from my VS code Thunder client. it worked as expected and didn't return 500. but, then the uploaded review on my kitsu doesn't look correct. Animation_62

MustafaJafar commented 3 days ago

I can't reproduce this issue any more. I can't tell when it was fixed. Animation_94

For information: I no longer need to hack around the code to add kitsu tag to the review family. I only need to update the kitsu addon settings.

image