search

ynput / ayon-nuke

Nuke addon for AYON
Apache License 2.0
4 stars 8 forks source link

Adding `AYON_LOG_NO_COLORS ` into prelaunch hooks #24

Open jakubjezek001 opened 1 month ago

jakubjezek001 commented 1 month ago

Is there an existing issue for this?

Please describe the feature you have in mind and explain what the current shortcomings are?

Nuke on Windows prints the Ayon logs in the console, but the logs appear colored. The console doesn't interpret the control sequences correctly, making the logs unreadable.

How would you imagine the implementation of the feature?

Adding AYON_LOG_NO_COLORS into default environment via prelaunch hook

{
    "AYON_LOG_NO_COLORS": "1"
}

image

Are there any labels you wish to add?

Describe alternatives you've considered:

No response

Additional context:

No response

jakubjezek001 commented 1 week ago

So it seems like AYON_LOG_NO_COLORS environment is not having any support in ayon-core. Or is ther other place to look at? @antirotor or @iLLiCiTiT ?

iLLiCiTiT commented 1 week ago

If it is must have, then I would not add it to settings, instead nuke addon can set it in add_implementation_envs on NukeAddon.

So it seems like AYON_LOG_NO_COLORS environment is not having any support in ayon-core. Or is ther other place to look at?

It is handled here https://github.com/ynput/ayon-core/blob/develop/client/ayon_core/lib/terminal.py#L42