search

ynput / ayon-resolve

AYON Addon for Blackmagic DaVinci Resolve
Apache License 2.0
4 stars 3 forks source link

Transfer editorial package to new publisher #36

Closed robin-ynput closed 1 month ago

robin-ynput commented 1 month ago

Changelog Description

Transfer editorial_pkg creator to new publisher. This contains changes from #12.

Note this is backward-compatible with previously save scene and published packages as metadata remains store under the same key VFX Notes which used to be referenced as api.lib.pype_tag_name but now becomes api.constants.AYON_TAG_NAME

Additional info

10-07-2024 (15-10-28)

Testing notes:

  1. Create a timeline
  2. Select this timeline
  3. Create a new editorial pkg from AYON Menu using Editorial Package creator
  4. Publish it
  5. Load the published timeline using the Loader
ynbot commented 1 month ago

Task linked: OP-8066 Resolve: update to new publisher

robin-ynput commented 1 month ago

@jakubjezek001 there is one side-effect I found with this update. When created the editorial_pkg instance adds new metadata into the timeline media_pool clip, which eventually get published. Then, when you load the result, the newly created timeline will bring back the editorial_pkg metadata used for its creation and this will mean a new instance might appear out of nowhere in the creator. Technically this makes sense, but I guess it could be confusing for the artist. Should we clear the editorial_pkg data upon loading ?

(hopefully I that make sense, sorry if not)

BigRoy commented 1 month ago

This should likely also be a if version is not None check because a version of 0 is technically a valid version?

jakubjezek001 commented 1 month ago

@jakubjezek001 there is one side-effect I found with this update. When created the editorial_pkg instance adds new metadata into the timeline media_pool clip, which eventually get published. Then, when you load the result, the newly created timeline will bring back the editorial_pkg metadata used for its creation and this will mean a new instance might appear out of nowhere in the creator. Technically this makes sense, but I guess it could be confusing for the artist. Should we clear the editorial_pkg data upon loading ?

(hopefully I that make sense, sorry if not)

Hey @robin-ynput, I tested the workflow and added some enhancements for loading and publishing data distribution. You can find the changes here: bfd9df5b7e93b7eb17f8d33573e7f7f9357c976c. The unified data distribution for loading and publishing is specific to this product type, as requested by the client.

robin-ynput commented 1 month ago

Thanks a lot @jakubjezek001 for your enhancements. Retested everything on my side as well, works perfectly. @BigRoy do you need more time to give an approval on this one ? I'd like to go ahead and merge it when possible.