Closed BigRoy closed 1 month ago
@moonyuet That's correct - I'm not sure what to do if no colorspace data is detected on the file. What "color conversion" do I apply in maketx
? None
? The .tx
files are intended to be in the colorspace of the renderer itself so without knowing the image colorspace just assuming the image is linear seems a bit odd. That's why I decided to skip conversions.
I could add a warning log if no conversions occurred at all for the instance? For now I've at least added debug logs.
@moonyuet That's correct - I'm not sure what to do if no colorspace data is detected on the file. What "color conversion" do I apply in
maketx
?None
? The.tx
files are intended to be in the colorspace of the renderer itself so without knowing the image colorspace just assuming the image is linear seems a bit odd. That's why I decided to skip conversions.I could add a warning log if no conversions occurred at all for the instance? For now I've at least added debug logs.
maybe adding the warning log would be helpful, just so the users know no colorspace data found meaning no tx files exported I also find out that the project configuration can be the root cause of no colorspace data found. I actually saved the workfile from the existing project. And the project configuration doesn't set up accordingly to the colorspace data(it could be the API limitation). We can actually mention the similar message which informs the users to check if they are using OCIO in the colorspace management in the project configuration.
I reset another project configuration to test, the tx file is published successfully. Will approve after the warning message has been added:)
Will approve after the warning message has been added:)
Added with https://github.com/ynput/ayon-substance-painter/pull/10/commits/46dc7f352ad25a37ef0e267cd22dcfae9ccad454 and apparently some debug logs I added recently were also not pushed yet.
@moonyuet can you review again?
Looks good now. Thank you!
Changelog Description
Generate .tx files for exported texture sets
Additional info
Needs testing.
TODO
Testing notes: