ynput / ayon-usd

USD Addon for AYON.
Apache License 2.0
5 stars 1 forks source link

updated bin bridge client to fix broken submodule #36

Closed Lypsolon closed 2 months ago

Lypsolon commented 2 months ago

Changelog Description

This PR fixes the bin bridge SubModule pointer as bin bridge used to import a module that was not available

Testing notes:

git clone recursive

BigRoy commented 2 months ago

Doesn't seem to workout for me. I checked out the branch, and then did:

>>> git submodule update --init --recursive
warning: unable to rmdir 'ayon_automator': Directory not empty
Submodule path 'client/ayon_usd/ayon_bin_client': checked out 'be73fc95b300f2f8c6d2275ae815c9f51261dcf5'
Cloning into 'E:/dev/ayon-usd/client/ayon_usd/ayon_bin_client/ayon_cicd_tools'...
remote: Repository not found.
fatal: repository 'https://github.com/ynput/AyonCiCd-Automator.git/' not found
fatal: clone of 'https://github.com/ynput/AyonCiCd-Automator.git' into submodule path 'E:/dev/ayon-usd/client/ayon_usd/ayon_bin_client/ayon_cicd_tools' failed
BigRoy commented 2 months ago

@Lypsolon tried again with https://github.com/ynput/ayon-usd/pull/36/commits/58e32324e2a314e648bd1aba75f147a41fb2ce30 yet still no luck running:

PS E:\dev\ayon-usd> git submodule update --init --recursive
Cloning into 'E:/dev/ayon-usd/client/ayon_usd/ayon_bin_client/ayon_cicd_tools'...
remote: Repository not found.
fatal: repository 'https://github.com/ynput/AyonCiCd-Automator.git/' not found
fatal: clone of 'https://github.com/ynput/AyonCiCd-Automator.git' into submodule path 'E:/dev/ayon-usd/client/ayon_usd/ayon_bin_client/ayon_cicd_tools' failed
Failed to clone 'ayon_cicd_tools'. Retry scheduled
Cloning into 'E:/dev/ayon-usd/client/ayon_usd/ayon_bin_client/ayon_cicd_tools'...
remote: Repository not found.
fatal: repository 'https://github.com/ynput/AyonCiCd-Automator.git/' not found
fatal: clone of 'https://github.com/ynput/AyonCiCd-Automator.git' into submodule path 'E:/dev/ayon-usd/client/ayon_usd/ayon_bin_client/ayon_cicd_tools' failed
Failed to clone 'ayon_cicd_tools' a second time, aborting
fatal: Failed to recurse into submodule path 'client/ayon_usd/ayon_bin_client'

You seem to be updating ayon_cicd but isn't the issue that it's in ayon_bin_client so you would need to point to a different commit in ayon bin client, that itself points to the fixed ayon_cicd, or?

Note that I have basically zero knowledge about git submodules.