search

ynqa / pandavro

Apache Avro <-> pandas DataFrame
MIT License
134 stars 32 forks source link

Adhere to Pandas API #8

Closed floscha closed 5 years ago

floscha commented 5 years ago

Since version 0.21.0, the pandas.from_csv() method is deprecated (see https://pandas.pydata.org/pandas-docs/stable/generated/pandas.DataFrame.from_csv.html). Instead, the signature pandas.read_csv() shall now be used. Consequentially, this PR renames from_avro() to read_avro but delegates from_avro() calls to read_avro in order to remain backward compatible.

ynqa commented 5 years ago

@floscha Thanks for your PR!

ynqa commented 5 years ago

LGTM! If change API name on README also, I will merge it.

ynqa commented 5 years ago

@floscha Thanks for fast dealing. And also please update verion 1.1.2 > 1.2.0, here. It's necessary to upload the changes to PyPI on travis ci.