Add flags - Githubissues

ynqa / wego

Word Embeddings in Go!

Apache License 2.0

474 stars 41 forks source link

Add flags #10

Closed ynqa closed 7 years ago

ynqa commented 7 years ago

Overview

Add flags for:
- Verbose to ignore unnecessary stdouts.
- DType to select gorgonia dtype from float32|float64.
- Profile to run with pprof.

ynqa commented 7 years ago

state.go has been more complicated than before...

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 50.523% when pulling a04b442dea1f02da639097faa255857865b94edd on addflag into 9a7942937550d84187c6c777abdd21be08141bd2 on develop.

coveralls commented 7 years ago

Coverage decreased (-0.9%) to 50.523% when pulling 8e1788ee28a1a3192563479dd0e631085792c374 on addflag into 9a7942937550d84187c6c777abdd21be08141bd2 on master.

chewxy commented 7 years ago

LGTM.

One note on potential optimization (not necessary, but good to keep in mind): instead of *model.Type being passes around, why not just model.Type. This reduces the chance that your code may be accidentally overwriting the Dtype or Engine

ynqa commented 7 years ago

I got it, thanks.