search

ynshung / better-yt-shorts

Playback, volume, timestamp controls and more on YouTube Shorts.
GNU General Public License v3.0
240 stars 43 forks source link

allow control/alt in keybindings #162

Closed SamiSuleiman closed 7 months ago

SamiSuleiman commented 11 months ago
SamiSuleiman commented 11 months ago

@ynshung @adsuth this relates to issue 32

SamiSuleiman commented 11 months ago

can you provide a video? it works locally 😕

SamiSuleiman commented 11 months ago

@adsuth I'll try to find a solution

adsuth commented 11 months ago

Actually scratch that its working fine for me now on mac. Must be something wrong with my chrome installation on pc, might need an update (that might explain other issues too)

There is a problem though in that global OS/browser binds like ctrl+ArrowLeft (on mac) or, again, ctrl+KeyO (on windows) won't be assignable.

Another issue is that command on mac (which is MetaLeft) cant be used for a multi-key bind. Not sure how we'd get passed that tbh as we definitely dont want the windows key to be used with binds. Maybe theres a way to see if the users on mac?

this link seems fruitful

SamiSuleiman commented 11 months ago

yeah, i was gonna look into a solution for shortcuts that conflict with the browser, I'll also look into the command key thing

ynshung commented 11 months ago

LGTM on my testing, it would be better if more people could also help test with this functionality to make sure it is fully functional