search

ynshung / better-yt-shorts

Playback, volume, timestamp controls and more on YouTube Shorts.
GNU General Public License v3.0
240 stars 43 forks source link

Stricter Typescript Linting #166

Closed ynshung closed 11 months ago

ynshung commented 11 months ago

Currently, there are two rules specifically no-explicit-any and no-unused-vars that are set to warning. One of the reason is the large volume of types that are set to any in the codebase. As such, any help is great to trace down the explicit types for each of them.

You can see the error by running npm run lint.

See #152 for more info

ynshung commented 11 months ago

Hi @tiagohconte you could help look through some of the remaining errors in the linting

tiagohconte commented 11 months ago

@ynshung Is there a reason why pingChanges on chromeEmitters.ts is disable?

tiagohconte commented 11 months ago

It's done on PR #170. I need some help to test if everything still works fine :smiley:

ynshung commented 11 months ago

@ynshung Is there a reason why pingChanges on chromeEmitters.ts is disable?

I think there's an error that made me comment out the function but I had forgotten what it is. I'm going to add it back since I had broken the auto update functionality😅