Volume slider disappear after navigation to the next shorts

ynshung / better-yt-shorts

Playback, volume, timestamp controls and more on YouTube Shorts.

GNU General Public License v3.0

240 stars 43 forks source link

Volume slider disappear after navigation to the next shorts #230

Closed Luke0094 closed 6 months ago

Luke0094 commented 8 months ago

Describe the bug If you return to the first short in the page the volume slider will disappear and will affect also the following shorts, this effect will remain until you don't manually refresh the page.

To Reproduce Steps to reproduce the behavior:

Open a short
Go to the second short
Get back to the first short
See error

Desktop (please complete the following information):

OS: Windows 11 build 22621.3085
Browser: Brave [Versione 1.63.138 Chromium: 121.0.6167.85 (Build ufficiale) beta (a 64 bit)]
Version of Better YouTube Shorts: v3.6.0

ynshung commented 8 months ago

This occurs to all shorts i.e. after viewing any shorts, go to the next shorts and go back to it the volume slider no longer appears

Waghabond commented 8 months ago

seekbar also breaks

Luke0094 commented 8 months ago

That is a recent addition after last patch (to be fair before it wasn't working at all).

Edit: Actually seem the problem now is with any short instead of only the first one, it should restart the correct behaviour after 2 skip.

tiagohconte commented 8 months ago

@ynshung @adsuth These recent issues are probably related to the Injection states. The injection is performed only on the first time a short is opened, when returning to the short the injections will not occur!

It looks like the Actions Elements is the only unit that doesn't have to be re-injected.