search

ynvaser / deckscraper

Magic the Gathering (MTG) reverse deck search tool.
18 stars 0 forks source link

Minimum card count for cubes to filter out small card lists #5

Open cbs38139 opened 1 year ago

cbs38139 commented 1 year ago

Would it be possible to add a minimum card count for cubes?

on CubeCobra, there are a lot of card lists (not cubes) with only a few cards in them. By adding a minimum card count (i.e. 180 or 360) it would be possible to filter out the majority of the bulk.

ynvaser commented 1 year ago

Hi!

Thanks for the suggestion. It's not a big change, I'll see if I can implement it when I have some time.

cbs38139 commented 1 year ago

Hi! Any chance you could implement it this summer? Then I could go cube hunting during my summer break :-)

ynvaser commented 1 year ago

Hi @cbs38139 ,

Dekkaru introduced some breaking changes in his bulk export file. I spent a few hours on it today, but it'll take me a bit more time to get that fixed. Stay tuned, I'll try to knock it out soon. I'll introduce this change you've requested as well. :)

cbs38139 commented 1 year ago

Hi! Any way I can help implementing this change?

ynvaser commented 1 year ago

Hey, sorry about the delay, I'm quite busy with the summer holiday period. I'll have some time in September.

cbs38139 commented 11 months ago

I am a big fan of your tool. Any chance you could implement the minimum count soon?

ynvaser commented 11 months ago

Sorry, life's kicking my butt this past few months. I'll get around to it when I can. In the meantime, if you want to contribute, submit a pull request with the changes.