search

yo-ru / gulag-web

The frontend appearance for the osu! server protocol, gulag!
MIT License
18 stars 26 forks source link

Fix grade counter on profiles being oddly inaccurate #39

Closed tsunyoku closed 3 years ago

tsunyoku commented 3 years ago

Don’t merge this yet, I realised an error in the grades: it should be ‘x’ not ‘ss’

tsunyoku commented 3 years ago

Ok, should be good to go now!

alowave223 commented 3 years ago

There is an unnecessary parameter here and it also breaks logging, seems like you pr'ed from an old version

tsunyoku commented 3 years ago

Probably, it’s taken from my fork which is a quite a few commits old. I’ll wait for @Yo-ru to see this and make the changes he wants.

varkaria commented 3 years ago

lgtm! ok i'll merge it

varkaria commented 3 years ago

oops i press wrong lmao