yoanbernabeu / Airtable-Client-Bundle

Simple Client for Airtable API
MIT License
33 stars 12 forks source link

chore: fix some missing php-doc #15

Closed yassinehamouten closed 2 years ago

yassinehamouten commented 3 years ago

Some missing return and thorw in php doc

yoanbernabeu commented 3 years ago

Thanks for the suggestions.

I too am hesitant. I like the idea that the PHPdoc is very complete, but actually, with TypeHitting, the code is self-documenting?

I am in favor of limiting the use of PHPdoc to what is strictly necessary. What do you think ?

yassinehamouten commented 3 years ago

Hello, Sorry i was busy these last few days.

I prefere to have the phpdoc + type hinting. But I understand your opinions.

So I will revert changes about php-doc 👍

yoanbernabeu commented 3 years ago

I propose to close this PR. Thanks for the proposal.

yassinehamouten commented 3 years ago

Hello, Sorry I was on vacation. This PR is now ok I think