[refactor] ☕ Short and simple method names

TangoMan75 commented 3 years ago

[refactor] ☕ Short and simple method names

🍬 1. Renamed `findTheLatest()` to `findLast()`

🔥 Affected files:

📝 README (line 72)
📂 src/AirtableClient (line 80)
📂 src/AirtableClientInterface (line 48)
✅ tests/AirtableClientTest (lines 211-248)

🍩 2. Renamed `addOneRecord()` to `add()`

🔥 Affected files:

📝 README (line 74)
📂 src/AirtableClient (line 113)
📂 src/AirtableClientInterface (line 57)
✅ tests/AirtableClientTest (lines 312-363)

🍰 3. Renamed `findOneById()` to `find()`

🔥 Affected files:

📝 README (line 65)
📂 src/AirtableClient (line 65)
📂 src/AirtableClientInterface (line 39)
✅ tests/AirtableClientTest (lines 267-293)

liorchamla commented 3 years ago

Great job of simplification here :)

I just noticed (and you will see it in the comments) that the add method of AirtableClient (and so AirtableClientInterface) should not force us to send an array for $fields, but an array OR an object.

Well played for the rest :)

yoanbernabeu commented 3 years ago

I'm back after a very busy work week!

This proposal is really good and it will simplify the use of the Bundle. Do you have time to resolve conflicts since the merge of PR #16 and #21 ?

Thank you !

TangoMan75 commented 3 years ago

Sure, I'll work on it... You're welcome

TangoMan75 commented 3 years ago

Conflicts solved... Ready for merge

TangoMan75 commented 3 years ago

Hi @yoanbernabeu 👋 I really enjoyed your last video about nocodb 👍 Great tool, thank you ! Are you still interested in my PR ? There are no more conflicts with main branch

yoanbernabeu / Airtable-Client-Bundle