search

yoanbernabeu / Airtable-Client-Bundle

Simple Client for Airtable API
MIT License
33 stars 12 forks source link

PHP-CS-FIXER and PHPStan #8

Closed Spomky closed 3 years ago

Spomky commented 3 years ago

This PR contains opiniated configurations for php-cs-fixer and phpstan. The current configuration for php-cs-fixer is limited to PSR2 rules. This PR adds a configuration file for php-cs-fixer and adds several rules you may disagree with (just ask if so!). In addition, this PR also adds a configuration file for PHPStan. Reached level is 8, which is the maximum at the time of writting.

Fixes #7 and introduces a new badge

ismail1432 commented 3 years ago

Hey @Spomky Thanks for this one ! TBH I am a bit confused for this level, I use this level at a daily basis and from my POV level 8 can be harder for newcomers, I like the idea of this bundle (straightforward and not too complex). It let the possibility to anyone to contribute to OSS without having a "deep" experience in PHP/Symfony... I totally agree that level 8 prevents of may bugs and help to prevent BC but it can also add some complexity for beginners/newcomers that want to contribute BUT we can also keep this level and keep in mind that some contributors can require our support to fix PHPStan errors

My 2 cents

Spomky commented 3 years ago

Hi @ismail1432,

Thank you for being honest. I agree with you; such a high level will undoubtedly generate frustration for newcomers (error messages may be hard to understand). I will decrease the level 5 or 6 that are much more simple to apprehend.

yoanbernabeu commented 3 years ago

I am ok for a level 5 or 6. It is accessible for the beginner (that I am 👌)