yoanlcq / vek

Generic 2D-3D math swiss army knife for game engines, with SIMD support and focus on convenience.
https://docs.rs/vek
Apache License 2.0
282 stars 32 forks source link

Build fails on 2020-10-04 #60

Closed zesterer closed 4 years ago

zesterer commented 4 years ago
   Compiling vek v0.12.0 (/home/joshua/Projects/vek)
error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
834 |     impl_all_beziers!{repr_simd}
    |     ---------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:428:30
    |
428 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: expected `,`
   --> src/bezier.rs:612:30
    |
612 |             pub start: $Point<T>,
    |                              ^
...
839 |     impl_all_beziers!{repr_c}
    |     ------------------------- in this macro invocation
    |
    = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to 8 previous errors

error: could not compile `vek`

To learn more, run the command again with --verbose.
yoanlcq commented 4 years ago

Hi, thanks for reporting this, I'll look into this ASAP.

zesterer commented 4 years ago

Thanks. This is confusing the heck out of me. cargo expand doesn't seem to show any bizarre code generation going on.

yoanlcq commented 4 years ago

Whoops I didn't mean to close this yet. I've submitted a workaround here. I'd like to see if CI builds successfully as well.

The workaround was to put the structs in their own isolated module, and then define a type Point<T> = $Point<T>, then replace all refs to $Point<T> with Point<T>.

However I do think that we should report this as a bug to the relevant team; basically, an update broke the build "for free" and I suspect too few people had the same problem.

yoanlcq commented 4 years ago

Well this looks fixed. One AppVeyor job choked on a connection error for whatever reason. I've published version 0.12.1 with the fix, hopefully this does the trick.

About reporting the bug to the Rust repo, I wish to do it sometime soon, provided that I don't forget about it...

zesterer commented 4 years ago

Thanks very much for the responsive fix!