Implement ``bytemuck`` traits for other common types

yoanlcq / vek

Generic 2D-3D math swiss army knife for game engines, with SIMD support and focus on convenience.

https://docs.rs/vek

Apache License 2.0

282 stars 32 forks source link

Implement ``bytemuck`` traits for other common types #92

Closed jedjoud10 closed 1 year ago

jedjoud10 commented 1 year ago

Implemented Zeroable and Pod for all Vec<T> types and their variants (simd and repr_c), Mat4<T>s, and for Quaternion

jedjoud10 commented 1 year ago

Hm seems like the CI itself fails. Pretty odd

yoanlcq commented 1 year ago

Hey, sorry for the delay, thanks for submitting this PR, it looks good. I have no idea what caused the appveyor failure even after seeing the logs.

What I'm going to do is merge this regardless, compile locally, and if it works I'll push a new version with this change.

yoanlcq commented 1 year ago

Done, available in 0.16.0 Thanks again!

jedjoud10 commented 1 year ago

Ah shoot it doesn't compile with the bytemuck feature. Such simple mistakes as well. Sorry so much about that, I should've tested and not relied on CI.

yoanlcq commented 1 year ago

No problem, I'll refer #94 from here