search

yoanlcq / vek

Generic 2D-3D math swiss army knife for game engines, with SIMD support and focus on convenience.
https://docs.rs/vek
Apache License 2.0
282 stars 32 forks source link

Fix compatibility with latest nightly toolchain version #95

Closed crabm4n closed 6 months ago

crabm4n commented 6 months ago

Platform intrinsics were removed and are replaced with core_intrinsics (now accessible via std::intrinsics::simd).

This is a breaking change as the simd_llvm and simd_traits which were publicly exported are removed.

xMAC94x commented 6 months ago

Hi @yoanlcq this MR is necessary for the veloren team to update the rust toolchain and newer toolschains had become incompatible with vek . do you have some time for a review? best regards, Marcel

yoanlcq commented 6 months ago

Hey guy, sorry for the delay! It's been a long 5-day week-end here in France.

This looks good to me. I was about to ask whether there was any way to be backwards compatible with prior compiler versions, but I guess there's no point: SIMD was always unstable and required explicit opt-in by using Nightly and enabling the platform_intrinsics feature. Plus, previous versions of vek are always available.

Thank you @crabm4n for your effort, I very much appreciate it. You have waited long enough, so I'll merge this right now, then push a new version. If you'd like to add yourself to the list of contributors (README + Cargo.toml) then feel free to do so even in a separate PR.

crabm4n commented 6 months ago

Thank you and no worries for the delay ;D

yoanlcq commented 6 months ago

This is now available in version 0.17.0 along with many warning fixes.

xMAC94x commented 6 months ago

Thank you very much. No worries, we all have a personal live that matter first. Waiting a few days is absolutely no issue :) Hope you enjoyed the long and sunny weekend :)