yoavbls / pretty-ts-errors

🔵 Make TypeScript errors prettier and human-readable in VSCode 🎀
https://marketplace.visualstudio.com/items?itemName=yoavbls.pretty-ts-errors
MIT License
13.14k stars 89 forks source link

Not showing any errors if vscode typescript validation is disabled and eslint enabled #67

Closed jpsantos7 closed 11 months ago

jpsantos7 commented 1 year ago

Describe the bug If a setting as such is used:

{
  "typescript.validate.enable": false, // <- this is the setting
  "eslint.validate": [
    "javascript",
    "javascriptreact",
    "typescript",
    "typescriptreact"
  ]
}

no errors pretty-ts-errors are displayed. only the ESLint ones as shown in the following image:

Screenshot 2023-06-21 at 23 12 52

If we change this to true we now get all 3 validations: which is not desirable:

Screenshot 2023-06-21 at 23 12 31

Expected behavior Being able to use the following setting and still be able to see the pretty errors and probably the eslint errors, but not the ts ones:

{
  "typescript.validate.enable": false
}
uigywnkiub commented 1 year ago

plx fix =)

yoavbls commented 11 months ago

Hey @jpsantos7, The extension can't work when the TypeScript validation is disabled because it uses that errors to generate the formatted ones. Unfortunately, until something changes in VSCode we can't hide the original messages, even though we want. We're tacking it here: https://github.com/yoavbls/pretty-ts-errors/issues/3

And someone else asked about formatting eslint errors. I haven't seen a point in that since the errors are pretty simple and not containing complex types but I'm willing to consider it if I'll see a good example