search

yoavram / curveball

Predicting microbial growth in a mixed culture from growth curve data
http://curveball.yoavram.com
Other
14 stars 5 forks source link

as_matrix depreciated in pandas #154

Closed chofski closed 4 years ago

chofski commented 4 years ago

Having attempted to run the fit_model function on data from the BioTekSynergy.xlsx example file I get an error that "as_matrix does not exist". This turns out to be due to the function being depreciated. This should instead be replaced with "to_numpy". In my patched version this now runs successfully.

yoavram commented 4 years ago

Would you be willing to open a pull request with your patch? Also are your sure it’s .to_numpy and not .values?

chofski commented 4 years ago

Either works. I'll push my patched version, but you might want to run some more thorough test to be sure this doesn't impact other parts of the codebase.