search

yoavram / markx

Markdown editor for scientific writing. Batteries included.
Other
319 stars 41 forks source link

private git repositories are not listed #32

Closed tolot27 closed 11 years ago

tolot27 commented 11 years ago

If I sign in to my GitHub account, only public repositories can be selected/opened.

Private repositories are commonly used by our group to share paper drafts. Hence, it would be great to have access to them as well.

yoavram commented 11 years ago

When the app stabilizes on the must have feature set this is planned to be added. Maybe earlier if it is really easy. You are welcome to look at the GitHub API docs and the Github.js javascript library and check if that is easy to implement.

yoavram commented 11 years ago

Hey I had another look - to do this you need to change user.userRepos(username, callback) to user.repos(callback) in markx.js. I'll try to do it later this week, but you can have a go at it and check it, from the quick test I did this returns a list of ALL the user repositories, including private ones and ones in which the user is a collaborator and not the owner.

yoavram commented 11 years ago

Now implemented in commit e29bbcf2262d877f0c1cfde327dfc94e505410e0 on branch codemirror, hopefully soon (by next week) merged to master and deployed to hosted app.

tolot27 commented 11 years ago

works great! Thx.