Bug in ONIX::Normaliser next_tempfile()

yob / onix

A convenient mapping between ruby objects and the ONIX XML specification

MIT License

39 stars 33 forks source link

Bug in ONIX::Normaliser next_tempfile() #1

Closed bekki closed 14 years ago

bekki commented 14 years ago

You will want to set the unlink_now option to true when you close the tempfile. The way it is right now, the file can actually be unlinked after you copy the old file to that location.

yob commented 14 years ago

Fix a race condition in ONIX::Normaliser

closed by 94cc36d12eff34a360702d9bb6ed93661c6dff11
reported by pixelvixen
to quote the report:

"You will want to set the unlink_now option to true when you close the tempfile. The way it is right now, the file can actually be unlinked after you copy the old file to that location."

yob commented 14 years ago

Cheers, this explains a few odd crashes I've experienced.