Anchor the match and look for leading %

yob / pdf-reader

The PDF::Reader library implements a PDF parser conforming as much as possible to the PDF specification from Adobe.

MIT License

1.82k stars 271 forks source link

Anchor the match and look for leading % #387

Closed sebbASF closed 3 years ago

yob commented 3 years ago

I'm not convinced this one is worthwhile. The match is on a 10 byte string, and the %PDF marker should be at the start of the line, but do we care if it's not?

If there's a real world issue this fixes then I'm all for it, but otherwise I don't think it's worth merging.