search

yob / pdf-reader

The PDF::Reader library implements a PDF parser conforming as much as possible to the PDF specification from Adobe.
MIT License
1.81k stars 271 forks source link

Ei after data #389

Closed sebbASF closed 2 years ago

sebbASF commented 2 years ago

This addresses #366

yob commented 2 years ago

The tests remain green, so this is looking pretty good!

I'd love to get a new spec in spec/integration_spec.rb that confirms we can successfully parse a PDF with this issue (and that main can't parse the same PDF).

It could be generated using the prawn fragment on #366, and I'd be happy if the test just extracted text (not necessarily the inline image itself.

yob commented 2 years ago

Thanks for the tests in #390.

I've confirmed the specs are green when run against this branch. I'd have been fine with the new specs being added directly to this PR as well ❤️